This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
sc_cli key insert
gives wrong name to _gran_ key file created in local keystorage (BREAKS blocks finalization)
#9888
Labels
J2-unconfirmed
Issue might be valid, but it’s not yet known.
Z7-question
Issue is a question. Closer should answer.
Comments
found in version:
|
agryaznov
changed the title
sp_cli
sp_cli Sep 28, 2021
key insert
gives wrong name to _gran_ key file created in local keystoragekey insert
gives wrong name to _gran_ key file created in local keystorage (BREAKS blocks finalization)
Figured out that: InsertKeyCmd run() function just assumes the default But shouldn't it implicitly derive the |
agryaznov
pushed a commit
to agryaznov/substrate-developer-hub.github.io
that referenced
this issue
Sep 29, 2021
Option 3: Use the `key` command --- corrected to workaround the #9888 issue (otherwise it just won't work for <gran> key) see paritytech/substrate#9888 for details
agryaznov
pushed a commit
to agryaznov/substrate-developer-hub.github.io
that referenced
this issue
Sep 29, 2021
Option 3: Use the `key` command --- corrected to workaround the #9888 issue (otherwise it just won't work for <gran> key) see paritytech/substrate#9888 for details
10 tasks
agryaznov
changed the title
sp_cli
sc_cli Sep 29, 2021
key insert
gives wrong name to _gran_ key file created in local keystorage (BREAKS blocks finalization)key insert
gives wrong name to _gran_ key file created in local keystorage (BREAKS blocks finalization)
nuke-web3
pushed a commit
to polkadot-developers/substrate-developer-hub.github.io
that referenced
this issue
Sep 29, 2021
Option 3: Use the `key` command --- corrected to workaround the #9888 issue (otherwise it just won't work for <gran> key) see paritytech/substrate#9888 for details
Thanks for the docs correction to specify scheme. I think this is OK to close, but possibly there should be a fix in the CLI's behavior to try and reason about if your key is correct or not. I will let the core team comment on that idea 🙏 |
nuke-web3
added
J2-unconfirmed
Issue might be valid, but it’s not yet known.
Z7-question
Issue is a question. Closer should answer.
labels
Sep 29, 2021
It doesn't know this. However, with this: #9909 the scheme will be required to be passed and not assumed anymore. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
J2-unconfirmed
Issue might be valid, but it’s not yet known.
Z7-question
Issue is a question. Closer should answer.
(found while passing this Tutorial)
Summary
key insert
gives a wrong name to file containing gran (ed25519) key, which effectively leads to broken GRANDPA finalization in nodeDetails
Performing the
key insert
command operation with pre-generated Alice' keyleads to creating these two files :
$ find /tmp/node01/chains/local_testnet/keystore -type f -printf "%f\n" 617572619effc1668ca381c242885516ec9fa2b19c67b6684c02a8a3237b6862e5c8cd7e 6772616e9effc1668ca381c242885516ec9fa2b19c67b6684c02a8a3237b6862e5c8cd7e
one of which is possibly wrong-named, as in their names:
61757261
encodes aura key type6772616e
encodes gran key typeand the other
9effc1668ca381c242885516ec9fa2b19c67b6684c02a8a3237b6862e5c8cd7e
part derives from public key, which should be different for aura (sr25519) and gran (ed25519), but it turns out to be just the same for bothhow it (supposedly) should work
if we just insert the same keys using JSON RPC (e.g. with this script), we get the gran key file named properly (and nodes finalizing blocks successfully)
$ find /tmp/node01/chains/local_testnet/keystore -type f -printf "%f\n" 617572619effc1668ca381c242885516ec9fa2b19c67b6684c02a8a3237b6862e5c8cd7e 6772616eb48004c6e1625282313b07d1c9950935e86894a2e4f21fb1ffee9854d180c781
The text was updated successfully, but these errors were encountered: