This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
pallet-multisig: Improve opaque call handling #10060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the opaque call was just a type redefinition of `Vec<u8>`. With metadata v14 that was breaking external tools, as they stopped looking at the type name. To improve the situation the `WrapperKeepOpaque` type is introduced that communicates to the outside the correct type info.
bkchr
added
A0-please_review
apopiak
reviewed
Oct 19, 2021
frame/multisig/src/lib.rs
Outdated
| /// Payment: `DepositBase` will be reserved if this is the first approval, plus | ||
| /// `threshold` times `DepositFactor`. It is returned once this dispatch happens or | ||
| /// is cancelled. | ||
| /// Payment: `DepositBase` will be reserved if this is the first appromes `DepositFactor`. |
There was a problem hiding this comment.
typo, did you want to change this comment?
ascjones
reviewed
Oct 19, 2021
shawntabrizi
approved these changes
Oct 25, 2021
|
bot merge |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* pallet-multisig: Improve opaque call handling Before the opaque call was just a type redefinition of `Vec<u8>`. With metadata v14 that was breaking external tools, as they stopped looking at the type name. To improve the situation the `WrapperKeepOpaque` type is introduced that communicates to the outside the correct type info. * Cleanup * Fix benchmarks * FMT
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* pallet-multisig: Improve opaque call handling Before the opaque call was just a type redefinition of `Vec<u8>`. With metadata v14 that was breaking external tools, as they stopped looking at the type name. To improve the situation the `WrapperKeepOpaque` type is introduced that communicates to the outside the correct type info. * Cleanup * Fix benchmarks * FMT
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the opaque call was just a type redefinition of
Vec<u8>. With metadata v14 that wasbreaking external tools, as they stopped looking at the type name. To improve the situation the
WrapperKeepOpaquetype is introduced that communicates to the outside the correct type info.Fixes: #10058