This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Strip out control codes from the logged messages #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koute
added
A0-please_review
bkchr
approved these changes
Oct 22, 2021
|
bot merge |
|
Waiting for commit status. |
bkchr
approved these changes
Nov 1, 2021
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
![paritytech-processbot[bot]](https://avatars.githubusercontent.com/in/144942?s=60&v=4){kind=small}
|
Why wasn't We need this for a custom panic handler - and copy-pasting cross-repos doesn't seem like a good idea. |
|
Because we don't wanted to create a crate for just one function and no, there is no other crate where this really fits into. |
|
There’s lots of other projects where this is a good idea (not just rusty
blockchains). Having a general crate to do it this one task well isn’t a
bad idea for the rust community. I’m not saying that created we would
definitely use it, but some projects surely would.
…On Thu, 6 Jan 2022 at 18:43, Bastian Köcher ***@***.***> wrote:
Because we don't wanted to create a crate for just one function and no,
there is no other crate where this really fits into.
—
Reply to this email directly, view it on GitHub
<#10081 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEJCA6E6IUEDCYFK2WDXDUUXPELANCNFSM5GQBGR6Q>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Strip out control codes from the logged messages * Also strip away C1 control codes * Add extra comments * Clear the buffer after flushing; rename `write` to `flush` * Move control code stripping into its own function * Also strip out control codes from panic messages * Also strip out Unicode left-to-right/right-to-left control codes
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Strip out control codes from the logged messages * Also strip away C1 control codes * Add extra comments * Clear the buffer after flushing; rename `write` to `flush` * Move control code stripping into its own function * Also strip out control codes from panic messages * Also strip out Unicode left-to-right/right-to-left control codes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.