This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make authorship soft deadline configurable. #10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-please_review
tomusdrw
added
C1-low
shawntabrizi
approved these changes
Oct 31, 2021
|
@tomusdrw thank you for taking care of this !! :) |
bkchr
suggested changes
Oct 31, 2021
| telemetry, | ||
| client, | ||
| include_proof_in_block_size_estimation: false, | ||
| _phantom: PhantomData, | ||
| } | ||
| } | ||
|
|
||
| /// Set soft deadline percentage. |
There was a problem hiding this comment.
This needs to be moved into the impl block below in line 177.
bkchr
approved these changes
Oct 31, 2021
librelois
approved these changes
Nov 18, 2021
|
@tomusdrw we are really interested in this PR, do you know if it will be merged soon? |
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for a18a243 |
|
bot merge |
|
Waiting for commit status. |
23 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Make soft deadline configurable. * cargo +nightly fmt --all * Move setter where it belongs.
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Make soft deadline configurable. * cargo +nightly fmt --all * Move setter where it belongs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on discussion in #9663 (comment)
The idea is to expose some public functions so that the soft deadline can actually be configured as a percentage of the hard deadline. Before it was hardcoded to 50%, now it's just the default and can be changed by the downstream projects.
This is especially useful for parachains, which have a pretty low absolute deadline (333ms). Note however that changing this parameter has security implications and setting it too high might end up opening a DoS vector, where block producers are forced to create & push empty blocks.