Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

rework staking::reap_stash #10178

Merged
merged 6 commits into from
Nov 14, 2021
Merged

rework staking::reap_stash #10178

merged 6 commits into from
Nov 14, 2021

Conversation

kianenigma
Copy link
Contributor

Changes reap-stash to be able to also reap an account that due to any reason have a ledger.active less than existential deposit. Also makes the transaction signed, but free in case of successful execution, for better protection.

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Nov 4, 2021
@kianenigma
Copy link
Contributor Author

kianenigma commented Nov 4, 2021

const ED = new BN(10000000000);
const ledgers = await api.query.staking.ledger.entries();
let count = 0;
let stale = 0;
for (let [ctrl, ledger] of ledgers) {
	const total = ledger.unwrapOrDefault().total;
	count += 1;
	if (total.toBn().lte(ED)) {
		stale += 1;
		console.log(`🚨 ${ctrl.args[0].toHuman()} has ledger ${api.createType('Balance', total).toHuman()}.`)
	}
}

console.log(`${stale} / ${count} are stale`);

unravels that there are 2275 out of 41990 garbage ledgers in polkadot, for instance.

Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few comments

frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved
frame/staking/src/pallet/mod.rs Outdated Show resolved Hide resolved
shawntabrizi and others added 3 commits November 10, 2021 19:47
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
@kianenigma kianenigma added B7-runtimenoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels Nov 12, 2021
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for 459359e

@kianenigma
Copy link
Contributor Author

bot merge

Copy link

@hellbill hellbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool👍

@viniul viniul added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 2, 2022
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* rework reap_stash

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Zeke Mostov <z.mostov@gmail.com>

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Zeke Mostov <z.mostov@gmail.com>

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Zeke Mostov <z.mostov@gmail.com>

* Fix

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
AurevoirXavier added a commit to darwinia-network/darwinia-common that referenced this pull request Aug 4, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* rework reap_stash

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Zeke Mostov <z.mostov@gmail.com>

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Zeke Mostov <z.mostov@gmail.com>

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Zeke Mostov <z.mostov@gmail.com>

* Fix

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants