This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Taskmanager: Remove clean_shutdown
#10314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason for this function, tokio already blocks automatically until all tasks are ended. Another reason to remove this feature is `mpsc_background_tasks` unbounded channel. Recently this channel was reporting too many unprocessed elements. We assume that this was a result of a lot of very shot lived tasks that somehow flooded this channel.
bkchr
added
A0-please_review
I don't quite get why Also, do you think a burn-in is justified here? |
Me neither. I checked the code that is called there and we don't use anything self build, most of the stuff is coming from the futures crate directly. Basically it maps down to a
This is nothing critical. This stuff was only used to ensure that all tasks are stopped before the node shuts down, nothing more. |
ordian
approved these changes
Nov 19, 2021
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Nov 19, 2021
|
bot merge |
|
Error: It's not possible to meet the minimal approval count of 1 in paritytech/polkadot#4336 |
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Nov 19, 2021
* Companion for Taskmanager: Remove `clean_shutdown` paritytech/substrate#10314 * Update Substrate * Remove warning
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Nov 30, 2021
* Companion for Taskmanager: Remove `clean_shutdown` paritytech/substrate#10314 * Update Substrate * Remove warning
23 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
There is no reason for this function, tokio already blocks automatically until all tasks are ended. Another reason to remove this feature is `mpsc_background_tasks` unbounded channel. Recently this channel was reporting too many unprocessed elements. We assume that this was a result of a lot of very shot lived tasks that somehow flooded this channel.
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
There is no reason for this function, tokio already blocks automatically until all tasks are ended. Another reason to remove this feature is `mpsc_background_tasks` unbounded channel. Recently this channel was reporting too many unprocessed elements. We assume that this was a result of a lot of very shot lived tasks that somehow flooded this channel.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason for this function, tokio already blocks automatically until all tasks are ended.
Another reason to remove this feature is
mpsc_background_tasksunbounded channel. Recently thischannel was reporting too many unprocessed elements. We assume that this was a result of a lot of
very shot lived tasks that somehow flooded this channel.
polkadot companion: paritytech/polkadot#4336
skip check-dependent-cumulus