This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp nomination pool reward scheme #11669
Revamp nomination pool reward scheme #11669
Changes from 81 commits
ea30833
00e8c87
fa5e95a
f2df79e
56cf997
508bc0a
f83944a
ac48c37
cbeb9fb
031040f
efc7b4f
60d42f1
02aa7d4
90db26e
5bf6d9c
1d8c940
2ec4857
a51e408
28c8852
c9413a2
433476d
c34b655
d0d75a1
a6afb06
a3a43e7
4b7b0c7
3f66688
640ec31
398ddfe
d5dc697
05fb517
f4dbd0a
0a79c80
78c0310
0fb1125
12773bb
ca475df
44a2722
f027faf
33b581c
c77613f
d69af2c
d318197
486a0e9
9b2113f
36cb484
723574b
624abe9
82287b0
e403fb1
4cad93a
221369b
696a55e
0689b58
bcb413c
bce40f7
8fc25ac
fc3ad18
03107f3
9f875a9
0513284
1c43f09
ef56db6
3da2364
ed5083f
3690489
62d35c8
1c840b2
7d9d403
78b79f2
a8ccd71
60b7641
a2082cd
ecb7890
7e56e1a
80b31c0
579da37
51c1608
3779081
9171a13
b9ab747
d4f45e7
ca47b05
f3e10a9
463ddfd
51873c7
c205ac3
69d1f9c
3efe9f5
84a2639
e7673f8
ed2c225
de9886d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an advantage of making migrations lenient in the error case?
I think this makes it harder to verify that it worked correctly, since the log must be checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What else can be done about it though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh… maybe for future migrations we can add a
strict
bool, which returns an error in case of corrupt storage.Then it could be re-run with
struct=false
if its deemed non-critical.Since when such a case happens, it means that there is a serous bug in a different part of the code that we should not miss. I dont know if the release engineers always check the log, i think its quite a lot of output.