Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-identity: Be more paranoid ;) #12170

Merged
merged 6 commits into from
Sep 8, 2022
Merged

pallet-identity: Be more paranoid ;) #12170

merged 6 commits into from
Sep 8, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Sep 2, 2022

Check that a registrar is providing judgement for the correct identity.

Check that a registrar is providing judgement for the correct identity.
@bkchr bkchr added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Sep 2, 2022
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prevents sticking a tx before the approve which changes the identity info

makes sense

@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Sep 5, 2022
@bkchr bkchr merged commit 8075aa4 into master Sep 8, 2022
@bkchr bkchr deleted the bkchr-identity-paranoid branch September 8, 2022 08:52
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* pallet-identity: Be more paranoid ;)

Check that a registrar is providing judgement for the correct identity.

* Fixes

* Fix alliance

* 🤦

* Fixes

* ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants