This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add Weightless benchmark bailing
#12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
approved these changes
Dec 2, 2022
| for i in 0..n { | ||
| let (caller, _curator, _fee, value, reason) = | ||
| setup_bounty::<T, I>(i, T::MaximumReasonLength::get()); | ||
| Bounties::<T, I>::propose_bounty(RawOrigin::Signed(caller).into(), value, reason)?; | ||
| let bounty_id = BountyCount::<T, I>::get() - 1; | ||
| let approve_origin = T::ApproveOrigin::successful_origin(); | ||
| let approve_origin = | ||
| T::SpendOrigin::try_successful_origin().map_err(|_| BenchmarkError::Weightless)?; |
There was a problem hiding this comment.
We should probably change all benchmarking code to use try_successful_origin and remove successful_origin?
There was a problem hiding this comment.
Yes eventually… this was an oversight when originally writing them.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
B7-runtimenoteworthy
C1-low
ghost
self-requested a review
ghost
approved these changes
Dec 2, 2022
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#6328 |
|
@coderobe this should set the weights for many of the (child)-bounty calls to zero for the Polkadot and Rococo runtime. |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Calls can be 'Weightless' Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix (child)-bounties benches Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Just use one dummy value Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Calls can be 'Weightless' Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix (child)-bounties benches Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Just use one dummy value Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (child)-bounties benchmark require
SpendOriginas dispatch origin. SinceSpendOriginis configured toNeverEnsureOriginin Polkadot, it is impossible to make these Calls since no origin instance can be created.This MR fixes this by:
Weightlessearly return option for benchmarks whose weight will be annotated with 0. It is not completly zero since users still pay theExtrinsicBaseWeightand a length-based fee.bountiesandchild-bountiesbenches.This is a better solution than #11562 since there would be a lot of ifs needed otherwise.
TODO:
These are not actually companions but needed to make the CI green:
Polkadot companion: paritytech/polkadot#6328
Cumulus companion: paritytech/cumulus#1940