This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Do not run slow running try state tests in CI #13286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
approved these changes
Jan 31, 2023
frame/staking/src/pallet/mod.rs
Outdated
| @@ -826,7 +826,7 @@ pub mod pallet { | |||
|
|
|||
| #[cfg(feature = "try-runtime")] | |||
| fn try_state(n: BlockNumberFor<T>) -> Result<(), &'static str> { | |||
| Self::do_try_state(n) | |||
| Self::do_try_state(n, TestMode::Fast) | |||
There was a problem hiding this comment.
Maybe we should support passing data into try_state so that we can run the full tests manually without code change.
There was a problem hiding this comment.
Yeah I think we should look into how we want to do this across pallets and have a way to run full test manually probably as an arg to on-runtime-upgrade instead of having to change code.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve try state running time in CI.
Should resolve paritytech/polkadot-sdk#234.