It's always false...

[gilescope]

I'm a bit suspicious of this code as it stands. It looks to me like either we can do this simplification, or maybe, the && should be ||? (but if that's the case we need to revisit the tests as they've encoded the current behaviour). Thoughts?

[gui1117]

seems correct, assets don't provide provider reference, only sufficient reference.

also the doc seems to mention provider where sufficient seems to be meant.

diff --git a/frame/assets/src/lib.rs b/frame/assets/src/lib.rs
index 894f8f3a4ab..868b23472a0 100644
--- a/frame/assets/src/lib.rs
+++ b/frame/assets/src/lib.rs
@@ -270,7 +270,7 @@ pub mod pallet {
                #[pallet::constant]
                type AssetDeposit: Get<DepositBalanceOf<Self, I>>;
 
-               /// The amount of funds that must be reserved for a non-provider asset account to be
+               /// The amount of funds that must be reserved for a non-sufficient asset account to be
                /// maintained.
                #[pallet::constant]
                type AssetAccountDeposit: Get<DepositBalanceOf<Self, I>>;
@@ -1477,7 +1477,7 @@ pub mod pallet {
                        Self::do_transfer_approved(id, &owner, &delegate, &destination, amount)
                }
 
-               /// Create an asset account for non-provider assets.
+               /// Create an asset account for non-sufficient assets.
                ///
                /// A deposit will be taken from the signer account.
                ///
diff --git a/frame/assets/src/types.rs b/frame/assets/src/types.rs
index d50461ba598..183b91c249f 100644
--- a/frame/assets/src/types.rs
+++ b/frame/assets/src/types.rs
@@ -58,8 +58,8 @@ pub struct AssetDetails<Balance, AccountId, DepositBalance> {
        pub(super) deposit: DepositBalance,
        /// The ED for virtual accounts.
        pub(super) min_balance: Balance,
-       /// If `true`, then any account with this asset is given a provider reference. Otherwise, it
-       /// requires a consumer reference.
+       /// If `true`, then account with this asset can be given a sufficient reference. Otherwise, it
+       /// requires a consumer reference or a deposit hold.
        pub(super) is_sufficient: bool,
        /// The total number of accounts.
        pub(super) accounts: u32,

[stale]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[gilescope]

bot merge