This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
improve run_benchmark #13935
Closed
improve run_benchmark #13935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ggwpez
suggested changes
Apr 17, 2023
| durations.push(duration.as_nanos()); | ||
| } | ||
| let durations: Vec<u128> = (0..50) | ||
| .into_par_iter() |
There was a problem hiding this comment.
These benches run serially since they otherwise influence each other.
Also this code is pretty dated and should eventually be removed (https://github.com/paritytech/substrate/issues/12218).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rayon to create parallel iterator, added map, and used sorted vector.