Soft deprecate GenesisConfig #14210
Soft deprecate GenesisConfig #14210
Conversation
juangirini
added
A0-please_review
juangirini
changed the title
juangirini
added
the
D3-trivial 🧸
| #fields | ||
| } | ||
|
|
||
| // TODO [#14065] | ||
| // - deprecate it |
There was a problem hiding this comment.
Could you maybe temporarily put a deprecation here, to see that the CI stays green and we got all cases?
There was a problem hiding this comment.
Sure, that's what I did locally. Let's double check with the CI, I will remove it after being confirmed
There was a problem hiding this comment.
@ggwpez all green now with the deprecation attribute in place, except for the Cumulus and Polkadot companions of course, as they are throwing the deprecation warning.
There was a problem hiding this comment.
Yes you can do them lean without companion (since that is annoying).
|
bot rebase |
…n-genesisconfig-runtimegenesisconfig
|
Rebased |
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 8121a6f |
| // TODO [#14065] | ||
| // - deprecate it | ||
| // - later, remove it |
There was a problem hiding this comment.
Personally I think it would be cleaner to not put TODO or deprecation steps in the code comment itself, and just list them in the issue.
The code comment could say something like "GenesisConfig is in the process of being deprecated [issue link]"
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
jg/14065-deprecation-genesisconfig-runtimegenesisconfig
branch
* soft deprecate genesisconfig * temporarily add a deprecation attr * update tests * update mocks * update genesis config * update genesis config * update genesis config * update genesis config * remove deprecation warning * update deprecation comment --------- Co-authored-by: parity-processbot <>
* soft deprecate genesisconfig * temporarily add a deprecation attr * update tests * update mocks * update genesis config * update genesis config * update genesis config * update genesis config * remove deprecation warning * update deprecation comment --------- Co-authored-by: parity-processbot <>
Relates to paritytech/polkadot-sdk#175
This PR Soft deprecates the runtime level
GenesisConfigby renaming it toRuntimeGenesisConfig.An alias
GenesisConfigis created to keep backwards compatibility. No deprecation warning has been added at this stage as that will happen later in a separate PR as indicated in paritytech/polkadot-sdk#175