This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
print error info for Database error in the sp-blockchain::Error
type.
#14248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project, when running the node, we meet the error:
2023-05-29 12:38:18 | 2023-05-29 04:38:17.993 WARN tokio-runtime-worker sc_service::client::client: Block import error: Database
Then the following blocks can not sync.
Look deep into the code, I know the error appear in the deep level of database, for example now we are using the rocksdb, so this error comes from the rockesdb.
However in the error log, the database error is dropped in the
sp-runtime::Error
type.And I think the error type
sp-database::DatabaseError
already implDebug
trait, so I think this error info can show in thesp-runtime::Error
also.substrate/primitives/database/src/error.rs
Lines 18 to 21 in b8d7dd5
In this pr, I plan to let this error info can contain the Database error info
substrate/primitives/blockchain/src/error.rs
Lines 152 to 156 in b8d7dd5