Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add test locking removed when amount is zero #14284

Merged
merged 3 commits into from
Jun 2, 2023
Merged

add test locking removed when amount is zero #14284

merged 3 commits into from
Jun 2, 2023

Conversation

jpserrat
Copy link
Contributor

@jpserrat jpserrat commented Jun 1, 2023 •
edited by liamaharon
Loading

Closes #14231

Hey @liamaharon, I've added the test when the amount is zero. Let me know if this is what you have in mind.

@jpserrat jpserrat requested review from a team June 1, 2023 12:45
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jun 1, 2023

User @jpserrat, please sign the CLA here.

liamaharon
liamaharon reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! While you're at it, could you please also check setting reasons to empty (WithdrawReasons::empty()) has the same behavior? See https://github.com/paritytech/substrate/pull/14144/files#diff-0848af5dac3286b1cf09718d38571925e65582729dedacceef836bb2278b612dR856-R859.

frame/balances/src/tests/currency_tests.rs Outdated Show resolved Hide resolved
@liamaharon liamaharon added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 1, 2023
@paritytech-ci paritytech-ci requested a review from a team June 1, 2023 14:49
@liamaharon liamaharon added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. and removed D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jun 1, 2023
@jpserrat
Copy link
Contributor Author

jpserrat commented Jun 1, 2023

Hey @liamaharon, thanks for the quick response! Just did the requested changes.

liamaharon
liamaharon approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs are preferred for indentation, before merging please fix by running cargo +nightly fmt -p pallet-balances

frame/balances/src/tests/currency_tests.rs Outdated Show resolved Hide resolved
@ggwpez
Copy link
Member

ggwpez commented Jun 2, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit da062e7 into paritytech:master Jun 2, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@jpserrat @nathanwhit
add test locking removed when amount is zero (paritytech#14284)
4d4ede8 
* add test locking removed when amount is zero

* add test set lock with withdraw reasons empty removes lock

* fix test set lock with withdraw reasons
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

balances pallet: test locks of zero
3 participants
@jpserrat @ggwpez @liamaharon