Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improves the EPM/Staking e2e test setup #14292

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

gpestana
Copy link
Contributor

@gpestana gpestana commented Jun 2, 2023

This PR improves the current staking/EPM e2e test setup, namely:

  • Uses a more realistic block progression with OCW
  • Runs try-state at the end of the tests for relevant pallets
  • Refactors the mock config trait implementation to use the Default through derive_impl

Helps with paritytech/polkadot-sdk#423

@gpestana gpestana added A0-please_review Pull request needs code review. I5-tests Tests need fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 2, 2023
@gpestana gpestana self-assigned this Jun 2, 2023
@gpestana gpestana requested review from a team June 2, 2023 13:22
@gpestana gpestana changed the title Gpestana/13589 e2e tests staking Improves the EPM/Staking e2e test setup Jun 2, 2023
@stale
Copy link

stale bot commented Jul 2, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Jul 2, 2023
@stale stale bot removed the A3-stale label Jul 4, 2023
Copy link
Contributor

@Ank4n Ank4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but overall LGTM!

@kianenigma
Copy link
Contributor

can be merged once conflict is resolved.

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 0d9d40d

@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit b975ee7 into master Jul 18, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the gpestana/13589-e2e_tests_staking branch July 18, 2023 11:09
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Adds onchainify to e2e tests; Adds try-runtime checks at the end of the tests

* Refactors OCW to be more realistic and to submit solutions during unsigned phase

* Uses config palllet Default impl in mock

* Improves OCW progression vode

* simplified OCW tests
Ank4n pushed a commit that referenced this pull request Jul 22, 2023
* Adds onchainify to e2e tests; Adds try-runtime checks at the end of the tests

* Refactors OCW to be more realistic and to submit solutions during unsigned phase

* Uses config palllet Default impl in mock

* Improves OCW progression vode

* simplified OCW tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I5-tests Tests need fixing, improving or augmenting. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants