Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Reimport WeightInfo in pallet-contracts #14358

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

kalaninja
Copy link
Contributor

When generating weights using benchmarks cli and default template here is the code that is generated:

impl<T: frame_system::Config> pallet_contracts::WeightInfo for WeightInfo<T>

in order for this to work WeightInfo, which is defined in weights module, should be re-imported (re-exported) from root.

@kalaninja kalaninja requested a review from athei as a code owner June 13, 2023 05:48
@kalaninja kalaninja requested a review from a team June 13, 2023 05:48
@bkchr bkchr requested a review from pgherveou June 13, 2023 07:42
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 13, 2023
@bkchr bkchr merged commit 19c0766 into master Jun 13, 2023
@bkchr bkchr deleted the kalaninja-contracts-weightinfo branch June 13, 2023 08:02
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants