Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sc-executor-wasmtime: Do not use absolute path to Cargo.toml in test #14370

Merged
merged 2 commits into from
Jun 13, 2023
Merged

sc-executor-wasmtime: Do not use absolute path to Cargo.toml in test #14370

merged 2 commits into from
Jun 13, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jun 13, 2023

As the test is executed inside the workspace, cargo metadata will automatically detect the correct Cargo.toml. This is required for the mono repo.

@bkchr
sc-executor-wasmtime: Do not use absolute path to Cargo.toml in test
1041877 
As the test is executed inside the workspace, `cargo metadata` will automatically detect the correct
`Cargo.toml`. This is required for the mono repo.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 13, 2023
@bkchr bkchr requested a review from a team June 13, 2023 15:30
@bkchr bkchr requested a review from koute as a code owner June 13, 2023 15:30
@bkchr
Copy link
Member Author

bkchr commented Jun 13, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jun 13, 2023 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2982898 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-4adec11a-2779-483f-b47a-48f12dc561e0 to cancel this command or bot cancel to cancel all commands in this pull request.

@bkchr
Copy link
Member Author

bkchr commented Jun 13, 2023

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 1041877

@command-bot
Copy link

command-bot bot commented Jun 13, 2023

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2982898 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2982898/artifacts/download.

@bkchr bkchr merged commit 297b394 into master Jun 13, 2023
@bkchr bkchr deleted the bkchr-wasmtime-test-do-not-use-absolute-path branch June 13, 2023 19:14
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
sc-executor-wasmtime: Do not use absolute path to Cargo.toml in test (
e612cd7 
paritytech#14370)

* sc-executor-wasmtime: Do not use absolute path to `Cargo.toml` in test

As the test is executed inside the workspace, `cargo metadata` will automatically detect the correct
`Cargo.toml`. This is required for the mono repo.

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@kpp kpp kpp approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @koute @kpp @ggwpez