This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
fix clippy warnings in node template #14390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepink-mas
force-pushed
the
node-clippy-fixes
branch
2 times, most recently
from
f6c6c02
to
fce6fb4
Compare
bkchr
approved these changes
Jun 15, 2023
ggwpez
approved these changes
Jun 15, 2023
ggwpez
added
A0-please_review
|
botmerge |
|
bot merge |
|
Error: Checks failed for fce6fb4 |
|
bot merge |
|
Waiting for commit status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some clippy warnings that turn up in the node-template when it becomes detached from the main substrate code base (and the clippy allow directives in its .cargo/config.toml) which happens when it is used as intended (a node template).