This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sc-tracing: Only print events for whitelisted targets #14487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only print events for whitelisted targets, otherwise we may run into some stack overflow while printing the event.
bkchr
added
A0-please_review
koute
approved these changes
Jul 3, 2023
michalkucharczyk
approved these changes
Jul 3, 2023
Co-authored-by: Koute <koute@users.noreply.github.com>
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 8e983f4 |
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
bkchr-tracing-check-for-allow-targets
branch
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* sc-tracing: Only print events for whitelisted targets We should only print events for whitelisted targets, otherwise we may run into some stack overflow while printing the event. * Update client/tracing/src/lib.rs Co-authored-by: Koute <koute@users.noreply.github.com> * Fix --------- Co-authored-by: Koute <koute@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only print events for whitelisted targets, otherwise we may run into some stack overflow while printing the event.