Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

node-template: Remove accidentally added dependency #14553

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jul 11, 2023

sc-statement-store isn't used by the template and thus, should not appear in the Cargo.toml.

Fixes comment: https://github.com/paritytech/substrate/pull/14387/files#r1260005073

`sc-statement-store` isn't used by the template and thus, should not appear in the `Cargo.toml`.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 11, 2023
@bkchr bkchr requested review from a team and ggwpez July 11, 2023 18:05
@bkchr bkchr merged commit edf58dc into master Jul 11, 2023
15 checks passed
@bkchr bkchr deleted the bkchr-fix-accidentally-added-dep branch July 11, 2023 18:55
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
`sc-statement-store` isn't used by the template and thus, should not appear in the `Cargo.toml`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants