Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Pallet balances quick updates #14557

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Pallet balances quick updates #14557

merged 2 commits into from
Jul 12, 2023

Conversation

pgherveou
Copy link
Contributor

Two minor updates addressing questions raised by our team this week:

  • Replace DispatchResultWithPostInfo with DispatchResult when the dispatchable only returns the default PostDispatchInfo.
  • Correct a comment in the currency trait that could be misinterpreted to suggest that the transfer method incurs fees.

@pgherveou pgherveou requested review from a team July 12, 2023 07:39
@pgherveou pgherveou added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 12, 2023
@pgherveou pgherveou requested a review from a team July 12, 2023 07:44
@pgherveou
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ebe8dcd into master Jul 12, 2023
4 checks passed
@paritytech-processbot paritytech-processbot bot deleted the pg/pallet_balances_quick_updates branch July 12, 2023 08:59
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@pgherveou @nathanwhit
quick updates (paritytech#14557)
39ffcb0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juangirini juangirini juangirini approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @juangirini @bkchr