This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove redundant sync primitives for metrics #14564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
added
A0-please_review
bkchr
approved these changes
Jul 13, 2023
Comment on lines
187
to
195
| } else if sender.warning_fired && | ||
| current_pending < sender.queue_size_warning.wrapping_div(2) | ||
| { | ||
| sender.warning_fired = false; | ||
| info!( | ||
| "Channel `{}` is no longer overflowed. Number of events: {}", | ||
| sender.name, current_pending | ||
| ); | ||
| } |
There was a problem hiding this comment.
Let's remove this. Otherwise it will get really spammy. This is just about saying "hey, there is somehing" and not on/off/on/off/on/off
There was a problem hiding this comment.
The information like on/off would be very useful when we want to debug networking issue. However, I agree that it could be quite spammy. What about emitting error! on the first trigger, and then indicate all subsequent free/busy events on info or even debug level?
Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com>
|
By the way, does anybody have an idea why benches job fails on this PR? |
|
You didn't used the latest master to create this pr. |
|
bot rebase |
|
Rebased |
bkchr
approved these changes
Jul 14, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
|
bot merge |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Remove redundant locks * Re-enable warning for a sender when a queue got processed * Apply suggestions from code review Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com> * Use debug for subsequent logging * Update client/network/src/service/out_events.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com> Co-authored-by: parity-processbot <>
Ank4n
pushed a commit
that referenced
this pull request
Jul 22, 2023
* Remove redundant locks * Re-enable warning for a sender when a queue got processed * Apply suggestions from code review Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com> * Use debug for subsequent logging * Update client/network/src/service/out_events.rs Co-authored-by: Bastian Köcher <git@kchr.de> --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Anton <anton.kalyaev@gmail.com> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since metrics struct can be safely send between threads (it has it's own locking logic around prometheus primitives) there is no need to do extra locking nor reference counting I assume.