This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce srml/im-online #3079
Introduce srml/im-online #3079
Changes from 29 commits
1e77e12
cfbec8c
5252851
1d5151b
2c89345
e9a9028
dc531dc
da1679b
eeb4df5
4895cad
b8fe709
2256919
0d1289b
44cd516
73f2bb5
56d25bd
5dc0298
5f43208
24adc6c
ec5f3e8
0d38749
fdbb2b4
39cd034
d256a3c
a7d9894
41091af
9bee5bf
f67d935
c7c0414
73fbc29
2e80426
e650c98
f88d9ee
0fb8a6b
607df96
0210000
7554808
f20a19b
e4ab8da
e3cea15
c5828e8
3f88973
537842d
1e50257
e73329f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this loaded by the networkservice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here: https://github.com/paritytech/substrate/pull/3079/files#diff-a045635f3eec17c06b3c7ac7944acceaR500, do you have concerns regarding the name "loading" being associated with the method
load()
?