This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Increase the reputation penality for being offline #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a random attempt at improving the number of active TCP connections (#4679) by increasing the reputation penalty for nodes being offline.
Right now it is only
-10, which actually immediately vanishes because reputations regress towards 0 at each tick.This reduces the chances that we try to connect to the the exact same node again in the near future.
I noticed locally that doing this change seems to improve the ratio of active per inactive connection.
Even if this doesn't improve anything, it's still a change in the right direction considering that right now that penalty might as well be 0.