Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Removes use of sc_client::Client from sc_consensus_babe #5014

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Removes use of sc_client::Client from sc_consensus_babe #5014

merged 2 commits into from
Feb 21, 2020

Conversation

seunlanlege
Copy link
Contributor

See #4452

@seunlanlege seunlanlege added the A0-please_review Pull request needs code review. label Feb 20, 2020
@parity-cla-bot
Copy link

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@seunlanlege
Copy link
Contributor Author

Pinging @andresilva @gnunicorn

@gnunicorn gnunicorn self-requested a review February 21, 2020 09:51
gnunicorn
gnunicorn approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

client/consensus/babe/src/lib.rs Outdated Show resolved Hide resolved
@gnunicorn gnunicorn added this to the 2.0 milestone Feb 21, 2020
@gnunicorn gnunicorn merged commit d8508d3 into master Feb 21, 2020
@gnunicorn gnunicorn deleted the seun-remove-client-babe branch February 21, 2020 11:13
General-Beck pushed a commit to General-Beck/substrate that referenced this pull request Mar 4, 2020
@seunlanlege @gnunicorn @General-Beck
Removes use of sc_client::Client from sc_consensus_babe (paritytech#5014
0cccd60 
)

* removes use of sc_client::Client from sc_consensus_babe

* Update client/consensus/babe/src/lib.rs

Co-authored-by: Benjamin Kampmann <ben.kampmann@googlemail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gnunicorn gnunicorn gnunicorn approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@Demi-Marie Demi-Marie Awaiting requested review from Demi-Marie

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seunlanlege @parity-cla-bot @gnunicorn