This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use libp2p's implementation of a wasm websocket transport #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So... that's technically a breaking change. |
|
@tomaka oh yeah, I'll make a polkadot PR too. |
NikVolf
reviewed
Mar 2, 2020
NikVolf
reviewed
Mar 2, 2020
|
Hey, I'd like to get this reviewed and merged soon if possible. |
tomaka
approved these changes
Mar 9, 2020
| @@ -26,25 +26,23 @@ use futures::{prelude::*, channel::{oneshot, mpsc}, future::{poll_fn, ok}, compa | |||
| use std::task::Poll; | |||
| use std::pin::Pin; | |||
| use sc_chain_spec::Extension; | |||
| use libp2p_wasm_ext::{ExtTransport, ffi}; | |||
tomaka
added
A8-looksgood
and removed
A0-please_review
|
could you add the appropriate b-label? |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 12, 2020
…h#5089) * Update to libp2p 0.16.2 * Use libp2ps implementation of a wasm websocket transport * Remove explicit Configuration type in node-cli Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
…h#5089) * Update to libp2p 0.16.2 * Use libp2ps implementation of a wasm websocket transport * Remove explicit Configuration type in node-cli Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #5088.