This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add more prometheus metrics to network::Protocol.
#5145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twittner
added
A0-please_review
gavofyork
approved these changes
Mar 5, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 6, 2020
mxinden
reviewed
Mar 16, 2020
| fork_targets: self.fork_targets.len().try_into().unwrap_or(std::u32::MAX), | ||
| finality_proofs: self.extra_finality_proofs.metrics(), | ||
| justifications: self.extra_justifications.metrics(), | ||
| _priv: () |
There was a problem hiding this comment.
@twittner am I understanding correctly that _priv is used to tell its consumer that the given structure might be extended in the future and that such an extension would not be a breaking change (see https://github.com/rust-lang/rfcs/blob/master/text/2008-non-exhaustive.md)?
Is this really necessary given that this is not exposed across crate boundaries?
There was a problem hiding this comment.
It was added to ensure that any Metrics value anywhere outside this module was created here. #[non_exchaustive] only works for downstream crates. It is probably not really necessary so if you feel strongly about it free to remove it.
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: paritytech/polkadot-sdk#562.