Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

removes use of sc_client::Client from sc_network #5147

Merged
merged 6 commits into from
Mar 12, 2020
Merged

removes use of sc_client::Client from sc_network #5147

merged 6 commits into from
Mar 12, 2020

Conversation

seunlanlege
Copy link
Contributor

see #4452

@seunlanlege seunlanlege added A0-please_review Pull request needs code review. B1-clientnoteworthy labels Mar 5, 2020
@seunlanlege seunlanlege added this to the 2.0 milestone Mar 5, 2020
@parity-cla-bot
Copy link

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

tomusdrw
tomusdrw reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

client/api/src/client.rs Outdated Show resolved Hide resolved
client/consensus/babe/rpc/src/lib.rs Show resolved Hide resolved
client/api/src/client.rs Outdated Show resolved Hide resolved
client/network/src/protocol/block_requests.rs Show resolved Hide resolved
client/src/client.rs Show resolved Hide resolved
@tomusdrw tomusdrw added A7-looksgoodtestsfail and removed A0-please_review Pull request needs code review. labels Mar 9, 2020
@gnunicorn
Copy link
Contributor

@seunlanlege needs merge and tests are failing.

expenses
expenses approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@expenses expenses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seunlanlege
Copy link
Contributor Author

@gnunicorn green check marks on tests.

gnunicorn
gnunicorn approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnunicorn gnunicorn merged commit ae36c62 into master Mar 12, 2020
@gnunicorn gnunicorn deleted the seun-remove-client-sc-network branch March 12, 2020 13:02
General-Beck pushed a commit to General-Beck/substrate that referenced this pull request Mar 12, 2020
@seunlanlege @General-Beck
removes use of sc_client::Client from sc_network (paritytech#5147)
5699d71 
* removes use of sc_client::Client from sc_network

* rename BlockProvider to BlockBackend

* fix broken test
General-Beck pushed a commit to General-Beck/substrate that referenced this pull request Mar 17, 2020
@seunlanlege @General-Beck
removes use of sc_client::Client from sc_network (paritytech#5147)
bfefbc2 
* removes use of sc_client::Client from sc_network

* rename BlockProvider to BlockBackend

* fix broken test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw left review comments

@gnunicorn gnunicorn gnunicorn approved these changes

@expenses expenses expenses approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@Demi-Marie Demi-Marie Awaiting requested review from Demi-Marie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@seunlanlege @parity-cla-bot @gnunicorn @tomusdrw @expenses