Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revert #5025 #5205

Closed

Conversation

shawntabrizi
Copy link
Member

This reverts #5025 which removed the Indices pallet from the Substrate Node Template.

This change, while reasonable in the context of Substrate, had impact on the Polkadot JS API, which made it harder for new developers to build their apps against the front-end libraries.

@shawntabrizi shawntabrizi added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Mar 10, 2020
@jacogr
Copy link
Contributor

jacogr commented Mar 10, 2020

I don't believe the template should work around the API. Since this same thing is applied in Kusama and will be in Polkadot, it is actually a sane change. So don't have a thumbs-up or thumbs-down to give here.

@shawntabrizi
Copy link
Member Author

@jacogr I think the context for an approval should be:

  • If the polkadot-js-api will not support the node-template out of the box, that will be a large net negative for our potential developers. If adding indices will solve that, I think it is an overall win.

  • We can always look to address a cleanup like this again in the future when there is less shit to fix.

If you agree, I think a thumbs up is the right response.

@JoshOrndorff
Copy link
Contributor

I prefer not to merge this revert. @shawntabrizi your reasons for removing indices in #5025 are good - makes the template simpler as a template should be. I'm willing to maintain Apps support for node template, and have made a PR to do so polkadot-js/apps#2364

@shawntabrizi
Copy link
Member Author

Sounds good @JoshOrndorff

Good on you here :)

@shawntabrizi shawntabrizi deleted the shawntabrizi-revert-indices branch March 10, 2020 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants