Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move fast benchmarks macro into frame_benchmarking #5445

Merged
merged 7 commits into from
Mar 31, 2020
Merged

Move fast benchmarks macro into frame_benchmarking #5445

merged 7 commits into from
Mar 31, 2020

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Mar 28, 2020 •
edited
Loading

This iterates on #5436.

  • Moves the macro to frame_benchmarking
  • Updates the name from pallet! to add_benchmark!
  • Update the syntax and construction of the macro just a little bit to pass the non-local variables to the rust macro.

    Its a little bit nasty, but imo not that bad.

  • Adds some docs.

@shawntabrizi shawntabrizi mentioned this pull request Mar 28, 2020
Merged
@shawntabrizi shawntabrizi added the A0-please_review Pull request needs code review. label Mar 28, 2020
@gui1117 gui1117 added A8-mergeoncegreen B0-silent Changes should not be mentioned in any release notes and removed A0-please_review Pull request needs code review. labels Mar 31, 2020
@shawntabrizi shawntabrizi merged commit ff98bb9 into gav-fast-benchmarks Mar 31, 2020
@shawntabrizi shawntabrizi deleted the shawntabrizi-fast-benchmarks branch March 31, 2020 11:25
gavofyork added a commit that referenced this pull request Mar 31, 2020
@gavofyork @shawntabrizi
Batch benchmarks together with * notation. (#5436)
5f51dd8 
* Batch benchmarks together with `*` notation.

* Fix short structopt conflict

* Return error if `batches` is empty

* Move fast benchmarks macro into `frame_benchmarking` (#5445)

* Move macro into `frame_benchmarking`

* Update docs

* Extra line

* Return error if `batches` is empty

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
@shawntabrizi
Companion PR for paritytech#5436/paritytech#5445 + paritytech#5463 (p…
1311c3d 
…aritytech#948)

* Use `add_benchmark` macro

* Return error if `batches` is empty

* Update Cargo.lock

* Companion for paritytech#5463 (paritytech#953)

* Fix test with genesis block 0

* Update Cargo.lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@NikVolf NikVolf Awaiting requested review from NikVolf

@gavofyork gavofyork Awaiting requested review from gavofyork

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawntabrizi @gui1117 @paritytech-ci