This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add more Prometheus metrics #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
Co-Authored-By: Max Inden <mail@max-inden.de>
Co-Authored-By: Max Inden <mail@max-inden.de>
Co-Authored-By: Max Inden <mail@max-inden.de>
romanb
reviewed
Apr 8, 2020
| @@ -868,6 +894,13 @@ impl Metrics { | |||
| kbuckets_num_nodes: register(Gauge::new( | |||
| "sub_libp2p_kbuckets_num_nodes", "Number of nodes in the Kademlia k-buckets" | |||
| )?, registry)?, | |||
| listeners_local_addresses: register(Gauge::new( | |||
| "sub_libp2p_listeners_local_addresses", "Number of local addresses we're listening on" | |||
There was a problem hiding this comment.
Suggested change
| "sub_libp2p_listeners_local_addresses", "Number of local addresses we're listening on" | |
| "sub_libp2p_listeners_addresses", "Number of addresses we're listening on" |
Aren't listener addresses always "local"?
There was a problem hiding this comment.
It's to differentiate with "external" addresses, that typically contain external IP addresses.
tomaka
added a commit
that referenced
this pull request
Apr 8, 2020
tomaka
added a commit
that referenced
this pull request
Apr 9, 2020
* Report local force-closing connections to Prometheus * Also report ping timeouts separately * Address concerns of #5571
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc paritytech/polkadot-sdk#560 (although none of the metrics I added are mentioned in this issue)
I think this adds all the metrics that we might want to have when it comes to low-level connections. Also modifies the
connectionsmetric to show the direction ("in" or "out").I'm going to test this out on my node, but you can start reviewing.