Ensure the listen addresses are consistent with the transport

client/network/src/error.rs

@@ -48,7 +48,9 @@ pub enum Error {
 		second_id: PeerId,
 	},
 	/// Prometheus metrics error.
-	Prometheus(prometheus_endpoint::PrometheusError)
+	Prometheus(prometheus_endpoint::PrometheusError),
+	/// Invalid configuration
+	InvalidConfiguration(String),
 }
 
 // Make `Debug` use the `Display` implementation.
@@ -65,6 +67,7 @@ impl std::error::Error for Error {
 			Error::Client(ref err) => Some(err),
 			Error::DuplicateBootnode { .. } => None,
 			Error::Prometheus(ref err) => Some(err),
+			Error::InvalidConfiguration(_) => None,
 		}
 	}
 }

client/network/src/service.rs

@@ -107,6 +107,27 @@ impl<B: BlockT + 'static, H: ExHashT> NetworkWorker<B, H> {
 	/// for the network processing to advance. From it, you can extract a `NetworkService` using
 	/// `worker.service()`. The `NetworkService` can be shared through the codebase.
 	pub fn new(params: Params<B, H>) -> Result<NetworkWorker<B, H>, Error> {
+		// Ensure the listen addresses are consistent with the transport
+		for addr in &params.network_config.listen_addresses {
+			if addr.iter().any(|x| matches!(x, libp2p::core::multiaddr::Protocol::Memory(_)))
+				&& !matches!(params.network_config.transport, TransportConfig::MemoryOnly) {
+				return Err(Error::InvalidConfiguration(format!(
+					"The network address {} is invalid because the transport is not set on {:?}",
+					addr,
+					TransportConfig::MemoryOnly,
+				)))
+			}
+
+			if !addr.iter().any(|x| matches!(x, libp2p::core::multiaddr::Protocol::Memory(_)))
+				&& matches!(params.network_config.transport, TransportConfig::MemoryOnly) {
+				return Err(Error::InvalidConfiguration(format!(
+					"The network address {} is invalid because the transport is set on {:?}",
+					addr,
+					TransportConfig::MemoryOnly,
+				)))
+			}
+		}
+
 		let (to_worker, from_worker) = tracing_unbounded("mpsc_network_worker");
 
 		if let Some(path) = params.network_config.net_config_path {

client/network/src/service/tests.rs

@@ -138,6 +138,7 @@ fn build_nodes_one_proto()
 
 	let (node2, events_stream2) = build_test_full_node(config::NetworkConfiguration {
 		notifications_protocols: vec![(ENGINE_ID, From::from(&b"/foo"[..]))],
+		listen_addresses: vec![],
 		reserved_nodes: vec![config::MultiaddrWithPeerId {
 			multiaddr: listen_addr,
 			peer_id: node1.local_peer_id().clone(),
@@ -342,3 +343,30 @@ fn lots_of_incoming_peers_works() {
 		future::join_all(background_tasks_to_wait).await
 	});
 }
+
+#[test]
+#[should_panic(expected = "the transport is set on MemoryOnly")]
+fn ensure_listen_addresses_consistent_with_transport_memory() {
+	let listen_addr = config::build_multiaddr![Ip4([127, 0, 0, 1]), Tcp(0_u16)];
+
+	let _ = build_test_full_node(config::NetworkConfiguration {
+		notifications_protocols: vec![(ENGINE_ID, From::from(&b"/foo"[..]))],
+		listen_addresses: vec![listen_addr.clone()],
+		in_peers: u32::max_value(),
+		transport: config::TransportConfig::MemoryOnly,
+		.. config::NetworkConfiguration::new("test-node", "test-client", Default::default(), None)
+	});
+}
+
+#[test]
+#[should_panic(expected = "the transport is not set on MemoryOnly")]
+fn ensure_listen_addresses_consistent_with_transport_not_memory() {
+	let listen_addr = config::build_multiaddr![Memory(rand::random::<u64>())];
+
+	let _ = build_test_full_node(config::NetworkConfiguration {
+		notifications_protocols: vec![(ENGINE_ID, From::from(&b"/foo"[..]))],
+		listen_addresses: vec![listen_addr.clone()],
+		in_peers: u32::max_value(),
+		.. config::NetworkConfiguration::new("test-node", "test-client", Default::default(), None)
+	});
+}