Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update Nicks docs to clarify that it is not production-ready #6990

Merged
merged 1 commit into from
Sep 7, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions frame/nicks/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
//!
//! ## Overview
//!
//! Nicks is a trivial module for keeping track of account names on-chain. It makes no effort to
//! create a name hierarchy, be a DNS replacement or provide reverse lookups.
//! Nicks is a non-production-ready module for keeping track of account names on-chain. It makes no
//! effort to create a name hierarchy, be a DNS replacement or provide reverse lookups. Furthermore,
//! the weights attached to this module's dispatchable functions are for demonstration purposes only
//! and have not been designed to be economically secure.
Comment on lines +25 to +28
Copy link
Contributor

@gui1117 gui1117 Sep 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what makes it "non-production-ready", the lack of features or the incorrect weights ?

The sentence seems to imply that the lack of feature makes it non-production ready but as far as I see only the incorrect weight is an issue here no ?

EDIT: with weight fixed, pallet should be production ready (though it doesn't provide much)

//!
//! ## Interface
//!
Expand Down