Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Send import notification always for re-orgs #7118

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Commits on Sep 16, 2020

  1. Send import notification always for re-orgs

    This pr changes the behavior of sending import notifications. Before we
    only send notifications when importing blocks on the tip of the chain or
    on similar conditions. However we did not send a notification when we
    for example being in a state where we import multiple blocks to catch
    up. If we re-org in this process, systems like the transaction pool
    would not be notified about this re-org. This means, that we would also
    not resubmit transactions of these retracted blocks. This pr fixes this,
    by always sending a notification on a re-org.
    
    See
    https://github.com/substrate-developer-hub/substrate-node-template/issues/82
    for some context about the bug.
    bkchr committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    0185864 View commit details
    Browse the repository at this point in the history
  2. Update client/service/src/client/client.rs

    Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
    bkchr and andresilva authored Sep 16, 2020
    Configuration menu
    Copy the full SHA
    684dedf View commit details
    Browse the repository at this point in the history