pallet-bounties | Sub-bounties Extn

[shamb0]

Sub-bounties Extn, Quick proto implemented for design discussion.

#7959

polkadot companion: paritytech/polkadot#2419

[xlc]

why are you modify the logic for master bounty other than check if it has active sub bounty?

[shawntabrizi]

@shamb0

Thanks for the PR and the work here!

Unfortunately we would like to put this PR on hold until after the parachains release due to resource constraints reviewing this PR in depth, and the number of critical upcoming changes that will be pushed to Polkadot and Kusama in the next couple of weeks.

The main issue here is that this update affects an existing pallet which is used in Polkadot, Kusama, and other parachain runtimes.

As such, we really need to make sure that all of this is right, from the benchmarking, to the state transitions, and even the game theory.

In general, it would be good that external contributions as large as this be isolated into a separate pallet so they can be more easily merged without us feeling that there will be such an impact to our networks.

Maybe we can still merge this by simply putting the code into a new crate, but as is, we will have to wait.

Thanks!

[shamb0]

Thanks @shawntabrizi, Able to understand the integration complexity. Like the suggested solution of managing as separate crate. Will work on it and get back ASAP.

[stale]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[rrtti]

Awaiting further actions from @shawntabrizi's team for guidance on this - possibly to deploy only on Kusama for now, and what would be the best way to do so.

[cla-bot-2021]

User @rajesh-nodle, please sign the CLA here.

[stale]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[rrtti]

Waiting for final review.

[shamb0]

Thanks for interest on the PR :-)) , will update to upstream master and get back ASAP 👍

[hanwencheng]

Any update on the PR? It seems only the CI need to be passed. We are waiting for this feature to be merged for Kusama Bounty #3

[stale]

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

[rrtti]

waiting for new changes.

[shamb0]

Hello Raul,

"New changes", Do you mean sync with upstream master ?

[gautamdhameja]

To address some of the feedback and make the sub-bounties logic loosely coupled with the bounties pallet, here is a proposed high-level redesign:

• Extract the sub-bounties logic in a separate pallet. Call it child-bounties pallet to avoid confusion (sub prefix is being used for substrate in some other places).
• In the bounties pallet, add a trait and config type for child-bounty manager. This trait will have the linking logic for checking child-bounties before closing a bounty, etc.
• In the runtime, we can assign the child-bounty pallet as the ChildBountyManager for Bounties pallet, or just () when not using child bounties.
• This is similar to how session uses SessionManager.

Thoughts?

cc/ @shawntabrizi

[shamb0]

Proposal sounds good for me 👍

[rrtti]

The Parity team will take over the redesign of the sub-bounties extension as a new pallet, based on @gautamdhameja's proposal above. They will extract the sub-bounties logic that is here in a separate pallet, add tests and becnhmarks and get it ready for review, deployment on Kusama and audit. I will proceed now to close this PR to continue the work somewhere else.