Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove grandpa StoredPendingChange shim #8788

Merged
2 commits merged into from
May 12, 2021
Merged

Remove grandpa StoredPendingChange shim #8788

2 commits merged into from
May 12, 2021

Conversation

ascjones
Copy link
Contributor

Fixes #1614.

Motivated by #8615 (comment), putting as a separate PR for easy review.

@ascjones ascjones added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 12, 2021
@ascjones ascjones requested a review from andresilva as a code owner May 12, 2021 07:46
@ascjones ascjones mentioned this pull request May 12, 2021
Merged
19 tasks
gui1117
gui1117 approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polkadot/kusama/westend do not have the old one stored.
I expect all networks to have updated but I am not completly familiar with grandpa.

@ascjones
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented May 12, 2021

Trying merge.

@ghost ghost merged commit c6a4752 into master May 12, 2021
@ghost ghost deleted the aj-remove-grandpa-shim branch May 12, 2021 16:35
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
@ascjones @nazar-pc
Remove grandpa StoredPendingChange shim (paritytech#8788)
5ea4749 
* Remove grandpa StoredPendingChange shim

* Unused import
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@gui1117 gui1117 gui1117 approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove GRANDPA compatibility shims when stabilized
3 participants
@ascjones @shawntabrizi @gui1117