Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-elections to pallet attribute macro #9088

Merged
3 commits merged into from
Jun 16, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Jun 12, 2021

Part of #7882.

Converts the Elections pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Elections pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Elections pallet.

@shaunxw shaunxw requested a review from kianenigma as a code owner June 12, 2021 03:55
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 12, 2021
@shawntabrizi
Copy link
Member

This pallet is not used in production, so should be totally non-breaking

frame/elections/src/lib.rs Outdated Show resolved Hide resolved
@gui1117
Copy link
Contributor

gui1117 commented Jun 16, 2021

bot merge

@ghost
Copy link

ghost commented Jun 16, 2021

Waiting for commit status.

@ghost ghost merged commit 63a0d0b into paritytech:master Jun 16, 2021
@shaunxw shaunxw deleted the sw/migrate-pallet-elections branch June 16, 2021 20:41
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants