Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Attempting to fix publishing #9140

Merged
35 commits merged into from
Jul 11, 2021
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
119c3b0
mark template and utils as non-publish
gnunicorn Jun 18, 2021
209007c
switch to development version for testing
gnunicorn Jun 18, 2021
1432177
activate unleash check
gnunicorn Jun 18, 2021
dc7c261
maybe if I disable all rules...
gnunicorn Jun 18, 2021
639560b
Fix isolated compilation of `max-encoded-len-derive` with `syn`
Xanewok Jun 14, 2021
02c0ae1
WIP: bump changes crates since v3 tag to next breaking
Xanewok Jun 18, 2021
7838337
Update lockfile
Xanewok Jun 18, 2021
3f81fed
WIP: Bump sp-transaction-pool as well
Xanewok Jun 18, 2021
6df80b9
WIP: Bump sp-offchain as well
Xanewok Jun 18, 2021
fb55d05
WIP: Bump frame-system-rpc-runtime-api as well
Xanewok Jun 18, 2021
583547c
WIP: Bump sp-authority-discovery as well
Xanewok Jun 18, 2021
5ee4167
Manually deactivate dev-deps before `cargo unleash check`
Xanewok Jun 18, 2021
53ca62f
Merge remote-tracking branch 'origin/master' into ben-fixing-for-unle…
Xanewok Jul 6, 2021
39b7ca8
Bump sp-consensus-slots
Xanewok Jul 6, 2021
ceb4d55
Add missing Cargo.lock change
Xanewok Jul 6, 2021
1bdd6b8
Bump sp-consensus-vrf as well
Xanewok Jul 6, 2021
d8d2f59
Bump sp-keyring as well
Xanewok Jul 6, 2021
c3b0cb5
Bump sp-consensus-pow as well
Xanewok Jul 6, 2021
3e72a8b
Try to speed up the `unleash-check` job
Xanewok Jul 6, 2021
a0c09b3
fixup: Ensure the temp target dir exists for unleash check
Xanewok Jul 6, 2021
e211518
Bump pallet-transaction-payment-rpc-runtime-api as well
Xanewok Jul 6, 2021
c65cd35
Bump pallet-transaction-payment-rpc as well
Xanewok Jul 6, 2021
b086576
Merge remote-tracking branch 'origin/master' into ben-fixing-for-unle…
Xanewok Jul 7, 2021
821a837
Try updating crates after patching in the Polkadot CI job
Xanewok Jul 7, 2021
dbe7ad8
Use another approach to update patched Substrate crates
Xanewok Jul 7, 2021
4dd3c5f
Try to update all sp-core versions in Polkadot CI job
Xanewok Jul 7, 2021
772f236
Simplify sp-core version checking
Xanewok Jul 7, 2021
e897db2
Apply another shellcheck lint
Xanewok Jul 7, 2021
201adc3
Just do the simplest thing I guess
Xanewok Jul 7, 2021
6948c08
Welp don't do --offline then
Xanewok Jul 7, 2021
b869dc7
Clean up `unleash-check` job triggers
Xanewok Jul 7, 2021
15a7709
Fix a note in unleash-check cache step
Xanewok Jul 7, 2021
d240da3
Merge remote-tracking branch 'origin/master' into ben-fixing-for-unle…
Xanewok Jul 10, 2021
42a5001
Add a note about temporary optimization in cargo-unleash
Xanewok Jul 10, 2021
666eae2
Pin a newer version of cargo-unleash
Xanewok Jul 10, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ variables: &default-vars
ARCH: "x86_64"
CI_IMAGE: "paritytech/ci-linux:production"
# FIXME set to release
CARGO_UNLEASH_INSTALL_PARAMS: "--version 1.0.0-alpha.11"
CARGO_UNLEASH_INSTALL_PARAMS: "--git https://github.com/paritytech/cargo-unleash"
Xanewok marked this conversation as resolved.
Show resolved Hide resolved
CARGO_UNLEASH_PKG_DEF: "--skip node node-* pallet-template pallet-example pallet-example-* subkey chain-spec-builder"

default:
Expand Down Expand Up @@ -326,13 +326,13 @@ test-linux-stable: &test-linux
unleash-check:
stage: test
<<: *docker-env
rules:
- if: $CI_PIPELINE_SOURCE == "pipeline"
when: never
- if: $CI_COMMIT_REF_NAME == "master"
- if: $CI_COMMIT_REF_NAME =~ /^v[0-9]+\.[0-9]+.*$/ # i.e. v1.0, v2.1rc1
<<: *test-refs-no-trigger
script:
- cargo install cargo-unleash ${CARGO_UNLEASH_INSTALL_PARAMS}
- cargo unleash de-dev-deps
# Reuse build artifacts when running checks (cuts down check time by 3x)
- mkdir -p target/unleash
- export CARGO_TARGET_DIR=target/unleash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not put in the variables: section above?

Copy link
Contributor

@Xanewok Xanewok Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a makeshift optimization that needs addressing in the tool itself and I didn't want to "properly" encode it here. Should I move it above for consistency for now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's fine to leave it as is then with the comment it's going to removed once cargo unleash addresses the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note

- cargo unleash check ${CARGO_UNLEASH_PKG_DEF}

test-frame-examples-compile-to-wasm:
Expand Down
7 changes: 7 additions & 0 deletions .maintain/gitlab/check_polkadot_companion_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,12 @@ fi
# Patch all Substrate crates in Polkadot
diener patch --crates-to-patch ../ --substrate --path Cargo.toml

# We need to update specifically our patched Substrate crates so that other
# crates that depend on them (e.g. Polkadot, BEEFY) use this unified version
# NOTE: There's no way to only update patched crates, so we use a heuristic
# of updating a crucial Substrate crate (`sp-core`) to minimize the impact of
# updating unrelated dependencies
cargo update -p sp-core

# Test Polkadot pr or master branch with this Substrate commit.
time cargo test --all --release --verbose
Loading