Remove in-tree max-encoded-len and use the new SCALE codec crate instead

[Xanewok]

Helps with #9140.

This PR uses the new version (git patch) of parity-scale-codec that's merged with the in-tree max-encoded-len crate. Since we don't plan to use/release this crate, this aims to gauge if using a hypothetical new release of the scale codec crate keeps the build running and tests passing, so that we can safely migrate and remove the max-encoded-len crate from the tree altogether.

It's worth noting that the in-tree version had some explicit impls for primitive hash types that but it's cleaner to implement these directly in the primitive-types crate (see fe797ff comment).

If the CI is green and this is accepted by reviews, we will need to release the locally patched crates to crates.io and then switch to them before this PR is merged.

Associated changes:
parity-scale-codec: https://github.com/paritytech/parity-scale-codec/compare/igor-max-encoded-len
primitive-types: https://github.com/paritytech/parity-common/compare/igor-prim-types-new-codec

polkadot companion: paritytech/polkadot#3412

[coriolinus]

With paritytech/parity-scale-codec#268 merged, MaxEncodedLen now exists on master of that repo.

[coriolinus]

Seems fine once the tests all pass.

[Xanewok]

As it turns out, if we want to proceed with using the pre-release, we need to explicitly select it (it's not considered SemVer-compatible), so this also requires:

• Bump parity-scale-codec to 2.2.0-rc.1 finality-grandpa#137
• Bump parity-scale-codec to 2.2.0-rc.1 trie#136
• Bump parity-scale-codec to 2.2.0-rc.2 scale-info#102 (looks like 0.7.0 including that will be released early next week)
• primitive-types/impl-codec: Bump to include new parity_scale_codec::MaxEncodedLen impls parity-common#552 (blocked on scale-info release above)

[Xanewok]

I'll fix the merge conflict and update the UI test once #9163 (comment) progresses.

[bkchr]

On a side note, please stop using force pushes ;)

[bkchr]

On a side note, please stop using force pushes ;)

[Xanewok]

https://gitlab.parity.io/parity/substrate/-/jobs/997661#L332

error: failed to select a version for `impl-codec`.
    ... required by package `primitive-types v0.9.0`
    ... which is depended on by `parity-util-mem v0.9.0`
    ... which is depended on by `kvdb v0.9.0`
    ... which is depended on by `kvdb-memorydb v0.9.0`
    ... which is depended on by `kvdb-web v0.9.0`
    ... which is depended on by `substrate-browser-utils v0.9.0 (/builds/parity/substrate/utils/browser)`
    ... which is depended on by `polkadot-cli v0.9.8 (/builds/parity/substrate/polkadot/cli)`
    ... which is depended on by `polkadot v0.9.8 (/builds/parity/substrate/polkadot)`
versions that meet the requirements `=0.5.0` are: 0.5.0
all possible versions conflict with previously selected packages.
  previously selected package `impl-codec v0.5.1`
    ... which is depended on by `sp-core v3.0.0 (/builds/parity/substrate/primitives/core)`
    ... which is depended on by `beefy-gadget v0.1.0 (https://github.com/paritytech/grandpa-bridge-gadget?branch=master#10872bb2)`
    ... which is depended on by `beefy-gadget-rpc v0.1.0 (https://github.com/paritytech/grandpa-bridge-gadget?branch=master#10872bb2)`
    ... which is depended on by `polkadot-rpc v0.9.8 (/builds/parity/substrate/polkadot/rpc)`
    ... which is depended on by `polkadot-service v0.9.8 (/builds/parity/substrate/polkadot/node/service)`
    ... which is depended on by `polkadot-cli v0.9.8 (/builds/parity/substrate/polkadot/cli)`
    ... which is depended on by `polkadot v0.9.8 (/builds/parity/substrate/polkadot)`
failed to select a version for `impl-codec` which could resolve this conflict

That doesn't make any sense, primitive types v0.9.0 has a ^0.5.0 dependency on impl-codec so it should be compatible with our new ^0.5.1 explicitly selected constrain in dec27e2...

Any ideas?

[Xanewok]

bot merge

[ghost]

Trying merge.