Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

include dispatch result in the Executed event #9315

Merged
4 commits merged into from
Jul 20, 2021
Merged

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Jul 9, 2021

So we can have some clue why it failed.

polkadot companion: paritytech/polkadot#3477

@xlc
Copy link
Contributor Author

xlc commented Jul 9, 2021

polkadot companion build error looks unrelated

Copy link
Contributor

@seunlanlege seunlanlege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this actually isn't a bad idea

@seunlanlege seunlanlege added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 12, 2021
@bkchr bkchr requested a review from shawntabrizi July 19, 2021 10:46
@kianenigma
Copy link
Contributor

companion build failing?

@xlc
Copy link
Contributor Author

xlc commented Jul 20, 2021

good now

@bkchr
Copy link
Member

bkchr commented Jul 20, 2021

bot merge

@ghost
Copy link

ghost commented Jul 20, 2021

Trying merge.

@ghost ghost merged commit 84f2d3d into paritytech:master Jul 20, 2021
@xlc xlc deleted the improve-event branch July 20, 2021 22:16
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants