This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Clarify wieght traits needed to impl in example #9842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
added
Z0-trivial
Writing the issue is of the same difficulty as patching the code.
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
and removed
Z0-trivial
Writing the issue is of the same difficulty as patching the code.
labels
Sep 23, 2021
nuke-web3
commented
Sep 23, 2021
gui1117
reviewed
Sep 23, 2021
gui1117
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably also improve the doc in frame/support/src/lib.rs when explaining about the pallet::weight attribute.
jimmychu0807
approved these changes
Sep 24, 2021
gui1117
reviewed
Sep 27, 2021
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
gilescope
approved these changes
Oct 11, 2021
bot merge |
Waiting for commit status. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered inconsistency with devhub here: polkadot-developers/substrate-developer-hub.github.io#1125
Add a required third trait in the docs as evidenced here:
substrate/frame/example/src/lib.rs
Lines 324 to 349 in eded990