Silence alert about large-statement-fetcher #9882
Conversation
That task is not continuous and behaving exactly as desired.
eskimor
added
A0-please_review
|
@tomaka Can you confirm pls? |
|
I'm in favor of removing the rule altogether due to nobody maintaining these exceptions in the list of tasks. |
I will file a PR doing just that, next time we get an unjustified alert. |
|
Can we not move this file entirely to Polkadot? It just doesn't make any sense to have the Polkadot alerting rules in Substrate repo... |
- Pierre thinks it does not add any value - Basti rightly complains that Polkadot specific exceptions make little sense in the Substrate repo.
I guess so. For now, I just removed the rule completely as suggested by @tomaka , in order to get rid of that 100% Polkadot exception. |
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: "Required status check "continuous-integration/gitlab-check-polkadot-companion-build" is failing." |
|
bot merge |
|
Trying merge. |
* master: (67 commits) Downstream `node-template` pull (#9915) Implement core::fmt::Debug for BoundedVec (#9914) Quickly skip invalid transactions during block authorship. (#9789) Add SS58 prefix for Automata (#9805) Clean up sc-peerset (#9806) Test each benchmark case in own #[test] (#9860) Add build with docker section to README (#9792) Simple Trait to Inspect Metadata (#9893) Pallet Assets: Create new asset classes from genesis config (#9742) doc: subkey usage (#9905) Silence alert about large-statement-fetcher (#9882) Fix democracy on-initialize weight (#9890) Fix basic authorship flaky test (#9906) contracts: Add event field names (#9896) subkey readme update on install (#9900) add feature wasmtime-jitdump (#9871) Return `target_hash` for finality_target instead of an Option (#9867) Update wasmtime to 0.29.0 (#9552) Less sleeps (#9848) remove unidiomatic (#9895) ...
That task is not continuous and behaving exactly as desired.
Fixes: paritytech/polkadot#3786