Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[DO NOT MERGE] CI: return cargo deny to PRs #9885

Closed
wants to merge 7 commits into from
Closed

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Sep 28, 2021

This will be put to the pre-merge pipeline (and maybe removed from the master/release ones after it)
After this gets merged it's going to be required for the merge and the same will be done in Pokadot paritytech/polkadot#925
cc https://github.com/paritytech/opstooling/issues/47 https://github.com/paritytech/ci_cd/issues/102

@TriplEight TriplEight added A0-please_review Pull request needs code review. A4-awaitingci C1-low PR touches the given topic and has a low impact on builders. labels Sep 28, 2021
@TriplEight TriplEight self-assigned this Sep 28, 2021
@TriplEight TriplEight requested a review from a team as a code owner September 28, 2021 16:56
@gilescope
Copy link
Contributor

we are getting there...

@stale
Copy link

stale bot commented Nov 11, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Nov 11, 2021
@gilescope
Copy link
Contributor

not dead yet. Gradually jasonrpsee is getting ready for prime time. At that time I think we can re-enable. (unless we just have an exclusion list with a link to related issues).

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Nov 15, 2021
@TriplEight
Copy link
Contributor Author

Also, I anticipate that failing on vulnerabilities won't be a desirable thing, right?
Making them just warn is not the best, too. So at some point, we'll create a metric and a matrix alert, or an automatic github issue that would summarize the vulnerabilities.

@TriplEight
Copy link
Contributor Author

as of now it still fails with a BlueOak license:

error[L001]: failed to satisfy license requirements
  ┌─ minicbor 0.8.0 (registry+https://github.com/rust-lang/crates.io-index):4:12
  │
4 │ license = "BlueOak-1.0.0"
  │            ^^^^^^^^^^^^^
  │            │
  │            license expression retrieved via Cargo.toml `license`
  │            rejected: not explicitly allowed

error[L003]: test-runner-example = 0.1.0 is unlicensed
  ┌─ test-runner-example 0.1.0 (path+file:///home/tripleight/code/github.com/paritytech/substrate/bin/node/test-runner-example):2:9
  │
2 │ name = "test-runner-example"
  │         ^^^^^^^^^^^^^^^^^^^ a valid license expression could not be retrieved for the crate
3 │ version = "0.1.0"
4 │ license = ""
  │            - license expression was not specified

error[L001]: failed to satisfy license requirements
  ┌─ minicbor-derive 0.6.2 (registry+https://github.com/rust-lang/crates.io-index):4:12
  │
4 │ license = "BlueOak-1.0.0"
  │            ^^^^^^^^^^^^^
  │            │
  │            license expression retrieved via Cargo.toml `license`
  │            rejected: not explicitly allowed

@stale
Copy link

stale bot commented Dec 22, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Dec 22, 2021
@stale stale bot closed this Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants