Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split subxt #102

Merged
merged 15 commits into from
May 12, 2020
Merged

Split subxt #102

merged 15 commits into from
May 12, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented May 4, 2020 •
edited
Loading

@ascjones all tests pass

@ascjones ascjones mentioned this pull request May 6, 2020
Closed
ascjones added a commit that referenced this pull request May 6, 2020
@ascjones
Temporary registration of Balance type before #102 merged
8f9c2cd
@ascjones ascjones mentioned this pull request May 6, 2020
Merged
ascjones added a commit that referenced this pull request May 6, 2020
@ascjones
Update to substrate alpha.7 release (#105)
f2c42f8 
* Update to substrate alpha.7

* Remove gas limit from contracts put code

* Rename SystemEvent::ReapedAccount to KilledAccount

* Log debug event received before attempting to decode

* Temporary registration of Balance type before #102 merged

* Show contract test errors, increase instantiate gas_limit
@ascjones
Copy link
Contributor

ascjones commented May 7, 2020

@dvc94ch thanks I'll take a look later today. Can you merge master again?

dvc94ch
dvc94ch commented May 7, 2020
View reviewed changes
src/events.rs Outdated Show resolved Hide resolved
ascjones
ascjones reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halfway through reviewing, some comments

proc-macro/src/store.rs Outdated Show resolved Hide resolved
proc-macro/src/test.rs Outdated Show resolved Hide resolved
proc-macro/src/test.rs Outdated Show resolved Hide resolved
src/events.rs Outdated Show resolved Hide resolved
src/frame/contracts.rs Outdated Show resolved Hide resolved
ascjones
ascjones reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just those unwraps to remove

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@dvc94ch dvc94ch requested a review from ascjones May 12, 2020 10:56
ascjones
ascjones approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit f861f3f into paritytech:master May 12, 2020
@ascjones ascjones mentioned this pull request May 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvc94ch @ascjones