Custom Debug impl for DispatchError
#1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
reviewed
Sep 7, 2023
lexnv
reviewed
Sep 11, 2023
| ), | ||
| }; | ||
|
|
||
| write!(f, "ModuleError(<{details}>)") |
There was a problem hiding this comment.
nit: Would it be beneficial to have this syntax ModuleError<..> also for the Display impl?
There was a problem hiding this comment.
Fine by me, wdyt @jsdw?
There was a problem hiding this comment.
I think the display impl can be "prettier" (it doesn't need to fit in with the rust like syntax that everything else spits out for debug impls), but perhaps we should indeed standardise these; maybe Debug should print ModuleError(<{details}>) as it does here and Display should just print {details}, so we can have a shared func to write details and then Debug just wraps to make fit better with rusty syntax?
lexnv
approved these changes
Sep 11, 2023
Merged
nanometerzhu
pushed a commit
to Phala-Network/substrate-subxt
that referenced
this pull request
Jan 25, 2024
* Custom `Debug` impl for `DispatchError`
* Implement suggestion
* Display bytes if details cannot be resolved
* Extract fn and use from Display impl
* Display just shows {details}
nanometerzhu
pushed a commit
to Phala-Network/substrate-subxt
that referenced
this pull request
Jan 25, 2024
* Custom `Debug` impl for `DispatchError`
* Implement suggestion
* Display bytes if details cannot be resolved
* Extract fn and use from Display impl
* Display just shows {details}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Debugimplementation prints the wholemetadatawhich fills the screen and doesn't help much:This PR adds a custom
Debugimpl which instead resolves to virtualpalletanderrorfields similar to theDisplayimpl. To know what the actual error is extremely useful 😄See also #1140 (comment)