Allow getting account nonce at arbitrary blocks, too #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Sep 29, 2023
niklasad1
approved these changes
Sep 29, 2023
lexnv
approved these changes
Sep 29, 2023
ascjones
approved these changes
Oct 2, 2023
tadeohepperle
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an
account_noncefunction onclient.tx()already, which fetches the account nonce based on the latest finalized block. In some cases (eg when usingmanual-sealin testing which doesn't produce finalized blocks), we'd like to be able to get the acocunt nonce for other blocks. So this just exposes it on the "blocks" API for that purpose, sharing the logic.