ChargeAssetTxPayment: support providing u32 or MultiLocation in default impl #1227
Conversation
|
Offhand the approach here looks good to me; keeps it simple and shows the user how to support MultiLocations via generated code or whatever :) |
There was a problem hiding this comment.
Looks good!
There's still a bit of me that is wondering whether it's better to expose AssetId as a config param like this, or to have an AssetId generic on ChargeAssetTxPayment and default it to u32, but then people can change it there instead.
Given that the signed extension and need to configure this feels like a fairly common thing, I do think that the approach in this PR is best for now though!
| @@ -51,6 +51,9 @@ pub trait Config: Sized + Send + Sync + 'static { | |||
|
|
|||
| /// This type defines the extrinsic extra and additional parameters. | |||
| type ExtrinsicParams: ExtrinsicParams<Self>; | |||
|
|
|||
| /// Asset Id | |||
| type AssetId: Debug + Encode; | |||
There was a problem hiding this comment.
This could also impl EncodeAsType possibly (same as a couple of the others above like singature I think), which would at least mean that if somebody tried setting a tip with an asset ID, and it was configured wrong, we'd get an EncodeAsType error back (eg because it failed to encode an Option<u32> into an Option<MultiLocation>) rather than have some error from the node that it failed to decode the tx provided.
For now I'd leave it as is, but we should probably consider moving some things in Config to EncodeAsType instead of Encode so that we get this extra protection.
There was a problem hiding this comment.
Might be worth an issue to not forget about it 🙏
Co-authored-by: James Wilson <james@jsdw.me>
tadeohepperle
deleted the
tadeohepperle/charge-asset-tx-payment-extension
branch
…lt impl (#1227) * Asset Id in Config trait * add example configuring the config * fmt * fix Default trait bound * merge examples, fix default again * adjust config in examples * Update subxt/src/config/mod.rs Co-authored-by: James Wilson <james@jsdw.me> --------- Co-authored-by: James Wilson <james@jsdw.me>
* skeleton commit * signed extension decoding * fix some minor things * make api more similar to Extrinsics * defer decoding of signed extensions * fix byte slices * add test for nonce signed extension * adjust test and extend for tip * clippy * support both ChargeTransactionPayment and ChargeAssetTxPayment * address PR comments * Extend lifetimes, expose pub structs, remove as_type * add signed extensions to block subscribing example * add Decoded type * fix merging bug and tests * add decoded type in CustomSignedExtension * fix minor issues, extend test * cargo fmt differences * remove the `decoded` function * new as_signed_extra fn, do not expose as_type anymore * fix Result-Option order, simplify obtaining Nonce * tx: Remove `wait_for_in_block` helper method (#1237) Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update smoldot to 0.12 (#1212) * Update lightclient Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * testing: Fix typo Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * testing: Update cargo.toml Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add tracing logs to improve debugging Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add socket buffers module for `PlatformRef` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Update `SubxtPlatform` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * cargo: Add lightclient dependencies Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update cargo.lock of wasm tests Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add constant for with-buffer module Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Replace rand crate with getrandom Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * example: Update cargo lock file Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * examples: Update deps Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Tadeo Hepperle <62739623+tadeohepperle@users.noreply.github.com> * ChargeAssetTxPayment: support providing u32 or MultiLocation in default impl (#1227) * Asset Id in Config trait * add example configuring the config * fmt * fix Default trait bound * merge examples, fix default again * adjust config in examples * Update subxt/src/config/mod.rs Co-authored-by: James Wilson <james@jsdw.me> --------- Co-authored-by: James Wilson <james@jsdw.me> * generic AssetId * fix generics * fmt --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: James Wilson <james@jsdw.me> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
fixes #1162