Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightclient: Fix wasm socket closure called after being dropped #1289

Merged
merged 10 commits into from
Nov 29, 2023
Merged

lightclient: Fix wasm socket closure called after being dropped #1289

merged 10 commits into from
Nov 29, 2023

Commits on Nov 23, 2023

  1. lightclient: Close wasm socket while dropping from connecting state 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f3eb4cd View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. lightclient: Construct one time only closures 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    cfac283 View commit details
    Browse the repository at this point in the history

  2. testing: Enable console logs for lightclient WASM testing 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    860f0e0 View commit details
    Browse the repository at this point in the history

  3. lightclient: Separate wakes and check connectivity on poll_read 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    8660940 View commit details
    Browse the repository at this point in the history

  4. lightclient: Close the socket depending on internal state 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b2e6d41 View commit details
    Browse the repository at this point in the history

  5. Revert "lightclient: Separate wakes and check connectivity on poll_read" 

    This reverts commit 8660940.
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    78f4d88 View commit details
    Browse the repository at this point in the history

  6. lightclient: Return pending if socket is opening from poll_read 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1cdee8f View commit details
    Browse the repository at this point in the history

  7. lightclient: Close the socket on poll_close 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    bd13879 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. lightclient: Reset closures on Drop to avoid recursive invokation 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    099f6ee View commit details
    Browse the repository at this point in the history

  2. lightclient: Close the socket if not already closing 

    Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
    @lexnv
    lexnv committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    abe77b5 View commit details
    Browse the repository at this point in the history