Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc5 #143

Merged
merged 6 commits into from
Jul 27, 2020
Merged

Rc5 #143

merged 6 commits into from
Jul 27, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Jul 25, 2020

Grr, tests don't work anymore.

Looks like it was caused by [0]. Extrinsics are UncheckedExtrinsics instead of OpaqueExtrinsics so the decoder is failing to parse the block as it expects hex encoded extrinsics.

All works now

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Jul 25, 2020

@dvc94ch it looks like you have not signed our contributor license aggreement yet. Please visit this link to sign our agreement. This pull request cannot be merged until the agrement is signed.

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Jul 25, 2020

@dvc94ch, Your signature has been received.

Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit e6f3a82 into paritytech:master Jul 27, 2020
@4meta5 4meta5 mentioned this pull request Jul 27, 2020
1 task
@ascjones ascjones mentioned this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants